Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Fix class name lexing #2097

Merged
merged 3 commits into from
Mar 27, 2022
Merged

Conversation

amitkummer
Copy link
Contributor

Fixes #2094.

The blockname state did not have a #pop after it's only rule, which caused outputting errors in #2094.

Instead of adding a #pop, I merged the blockname state with the rule that uses it, to achieve the exact same lexing logic, but without another state in the lexer.

The `blockname` state did not have a `#pop` after it's only rule,
which caused outputting errors in pygments#2094.

Instead of adding a `#pop`, I merged the `blockname` state with the
rule that uses it, to achieve the exact same lexing logic, but without
another state in the lexer.
@Anteru Anteru self-assigned this Mar 27, 2022
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Mar 27, 2022
@Anteru Anteru added this to the 2.12.0 milestone Mar 27, 2022
@Anteru Anteru merged commit f06f6d6 into pygments:master Mar 27, 2022
@Anteru
Copy link
Collaborator

Anteru commented Mar 27, 2022

Merged, thanks a lot!

@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Mar 27, 2022
@lorengordon
Copy link

Curious if there's a date for the next release? Would like to see if this also fixes the basic HCL syntax issue reported in #1353 ...

@Anteru
Copy link
Collaborator

Anteru commented Apr 23, 2022

It should be any moment now, I'm just having trouble finding some time to push it across the finish line.

@lorengordon
Copy link

That did the trick, thanks @Anteru!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform comments are highlighted as errors
3 participants